From 949c10f9f362b4021b933b8a95bf986f443fd2ce Mon Sep 17 00:00:00 2001
From: Martin Berg Alstad <600878@stud.hvl.no>
Date: Tue, 11 Jul 2023 20:58:22 +0200
Subject: [PATCH] Started with ActionService tests

---
 BackendTests/BackendTests.csproj             |  1 +
 BackendTests/Services/ActionServiceTests.cs  | 32 +++++++++++++++++---
 pac-man-board-game/Services/ActionService.cs | 15 +++++++--
 3 files changed, 42 insertions(+), 6 deletions(-)

diff --git a/BackendTests/BackendTests.csproj b/BackendTests/BackendTests.csproj
index 9a53779..06e3e3f 100644
--- a/BackendTests/BackendTests.csproj
+++ b/BackendTests/BackendTests.csproj
@@ -10,6 +10,7 @@
 
     <ItemGroup>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
+        <PackageReference Include="NSubstitute" Version="5.0.0" />
         <PackageReference Include="NUnit" Version="3.13.3" />
         <PackageReference Include="NUnit3TestAdapter" Version="4.2.1" />
         <PackageReference Include="NUnit.Analyzers" Version="3.3.0" />
diff --git a/BackendTests/Services/ActionServiceTests.cs b/BackendTests/Services/ActionServiceTests.cs
index fe97d3b..00b8bef 100644
--- a/BackendTests/Services/ActionServiceTests.cs
+++ b/BackendTests/Services/ActionServiceTests.cs
@@ -1,13 +1,34 @@
+using Microsoft.Extensions.Logging;
+using NSubstitute;
+using pacMan.Game;
+using pacMan.Interfaces;
+using pacMan.Services;
+
 namespace BackendTests.Services;
 
 public class ActionServiceTests
 {
+    private IActionService _service = null!;
+    private IWebSocketService _wssMock = null!;
+
+    [SetUp]
+    public void Setup()
+    {
+        _wssMock = Substitute.For<WebSocketService>(Substitute.For<ILogger<WebSocketService>>());
+        _service = new ActionService(Substitute.For<ILogger<ActionService>>(), _wssMock);
+    }
+
     #region RollDice()
 
     [Test]
     public void RollDice_ReturnsListOfIntegers()
     {
-        Assert.Fail();
+        var dices = _service.RollDice();
+        Assert.Multiple(() =>
+        {
+            Assert.That(dices, Has.Count.EqualTo(2));
+            Assert.That(dices, Has.All.InRange(1, 6));
+        });
     }
 
     #endregion
@@ -17,7 +38,10 @@ public class ActionServiceTests
     [Test]
     public void PlayerInfo_DataIsNull()
     {
-        Assert.Fail();
+        var message = new ActionMessage { Action = GameAction.PlayerInfo, Data = "null" };
+        Assert.Throws<NullReferenceException>(() => _service.PlayerInfo(message));
+        message.Data = null;
+        Assert.Throws<NullReferenceException>(() => _service.PlayerInfo(message));
     }
 
     [Test]
@@ -57,13 +81,13 @@ public class ActionServiceTests
     {
         Assert.Fail();
     }
-    
+
     [Test]
     public void Ready_SomeReady()
     {
         Assert.Fail();
     }
-    
+
     [Test]
     public void Ready_AllReady()
     {
diff --git a/pac-man-board-game/Services/ActionService.cs b/pac-man-board-game/Services/ActionService.cs
index b557c99..84ed575 100644
--- a/pac-man-board-game/Services/ActionService.cs
+++ b/pac-man-board-game/Services/ActionService.cs
@@ -1,4 +1,5 @@
 using System.Text.Json;
+using Microsoft.CSharp.RuntimeBinder;
 using pacMan.Game;
 using pacMan.Game.Interfaces;
 using pacMan.Game.Items;
@@ -51,8 +52,18 @@ public class ActionService : IActionService // TODO tests
 
     public List<IPlayer> PlayerInfo(ActionMessage message)
     {
-        _player = JsonSerializer.Deserialize<Player>(message.Data);
-        _group = _wsService.AddPlayer(_player);
+        try
+        {
+            _player = JsonSerializer.Deserialize<Player>(message.Data);
+            _group = _wsService.AddPlayer(_player);
+        }
+        catch (RuntimeBinderException e)
+        {
+            Console.WriteLine(e);
+            if (message.Data == null) throw new NullReferenceException();
+
+            throw;
+        }
 
         return _group.Players;
     }